Skip to content

ref: Remove deprecated integrations option #6492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ref: Remove deprecated integrations option #6492

wants to merge 2 commits into from
+81 −298

Conversation

@noahsmartin
Copy link
Contributor

@noahsmartin noahsmartin commented Oct 21, 2025 •
edited by github-actions bot
Loading

Remove this setting that is deprecated and removed in the v9 flag

#skip-changelog

Closes #6544

@codecov
Copy link

codecov bot commented Oct 21, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@70eb95e). Learn more about missing BASE report.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             main     #6492   +/-   ##
========================================
  Coverage        ?   85.354%           
========================================
  Files           ?       451           
  Lines           ?     27421           
  Branches        ?     11933           
========================================
  Hits            ?     23405           
  Misses          ?      3972           
  Partials        ?        44
Files with missing lines Coverage Δ
SentryTestUtils/TestOptions.swift 100.000% <100.000%> (ø)
Sources/Sentry/SentryOptions.m 96.407% <ø> (ø)
Sources/Sentry/SentrySDKInternal.m 83.266% <ø> (ø)
Sources/Sentry/SentyOptionsInternal.m 99.543% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70eb95e...3750705. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2025 •
edited
Loading

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1237.60 ms 1271.82 ms 34.21 ms
Size 23.75 KiB 1.01 MiB 1016.23 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
b9ceffb 1222.57 ms 1247.96 ms 25.39 ms
3133d0e 1237.86 ms 1262.87 ms 25.01 ms
9add417 1224.33 ms 1243.06 ms 18.73 ms
07f6759 1232.98 ms 1267.59 ms 34.61 ms
8ad303c 1220.02 ms 1231.79 ms 11.77 ms
c4b0360 1235.68 ms 1252.65 ms 16.97 ms
8fd192f 1202.10 ms 1220.19 ms 18.09 ms
42cfd79 1222.13 ms 1244.23 ms 22.10 ms
25f2d2c 1232.02 ms 1242.78 ms 10.76 ms
5712478 1220.10 ms 1239.69 ms 19.59 ms

App size

Revision Plain With Sentry Diff
b9ceffb 23.75 KiB 969.07 KiB 945.32 KiB
3133d0e 23.74 KiB 976.79 KiB 953.04 KiB
9add417 23.75 KiB 908.40 KiB 884.65 KiB
07f6759 23.75 KiB 997.26 KiB 973.52 KiB
8ad303c 23.75 KiB 879.24 KiB 855.49 KiB
c4b0360 23.75 KiB 946.69 KiB 922.94 KiB
8fd192f 23.74 KiB 872.75 KiB 849.01 KiB
42cfd79 23.75 KiB 880.20 KiB 856.45 KiB
25f2d2c 23.75 KiB 866.69 KiB 842.94 KiB
5712478 23.75 KiB 969.28 KiB 945.54 KiB

Previous results on branch: removeDeprecatedIntegrations

Startup times

Revision Plain With Sentry Diff
ff29e12 1214.66 ms 1248.91 ms 34.25 ms
75209a9 1217.91 ms 1248.78 ms 30.87 ms
2b2ee5a 1237.29 ms 1265.98 ms 28.69 ms
08c8d7a 1220.77 ms 1260.15 ms 39.38 ms
d35abd8 1219.20 ms 1258.71 ms 39.50 ms

App size

Revision Plain With Sentry Diff
ff29e12 23.75 KiB 1.01 MiB 1006.39 KiB
75209a9 23.75 KiB 1.00 MiB 1005.77 KiB
2b2ee5a 23.75 KiB 1.00 MiB 1005.77 KiB
08c8d7a 23.75 KiB 1.00 MiB 1002.23 KiB
d35abd8 23.75 KiB 1.01 MiB 1008.62 KiB

@noahsmartin noahsmartin force-pushed the removeDeprecatedIntegrations branch 3 times, most recently from 87033d4 to 310a2a6 Compare October 23, 2025 16:50
@noahsmartin noahsmartin marked this pull request as ready for review October 27, 2025 15:34
This was referenced Oct 27, 2025
Open
Open
cursor[bot]

This comment was marked as outdated.

Sign in to view

itaybre
itaybre reviewed Oct 27, 2025
View reviewed changes
itaybre
itaybre reviewed Oct 27, 2025
View reviewed changes
@noahsmartin noahsmartin force-pushed the removeDeprecatedIntegrations branch from 310a2a6 to 85715ad Compare October 27, 2025 16:32
cursor[bot]

This comment was marked as outdated.

Sign in to view

@noahsmartin noahsmartin force-pushed the removeDeprecatedIntegrations branch from 85715ad to 51eada2 Compare October 27, 2025 16:49
itaybre
itaybre approved these changes Oct 27, 2025
View reviewed changes
Copy link
Contributor

@itaybre itaybre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noahsmartin noahsmartin force-pushed the removeDeprecatedIntegrations branch from 51eada2 to 341c2cc Compare October 28, 2025 17:41
@noahsmartin noahsmartin force-pushed the removeDeprecatedIntegrations branch from 341c2cc to 3750705 Compare October 28, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@itaybre itaybre itaybre approved these changes

@philipphofmann philipphofmann Awaiting requested review from philipphofmann philipphofmann is a code owner

@philprime philprime Awaiting requested review from philprime philprime is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ref: Remove deprecated integrations option

3 participants

@noahsmartin @itaybre